Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Limit & Sort with Filter #97

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix Limit & Sort with Filter #97

merged 1 commit into from
Nov 8, 2024

Conversation

neo-garaix
Copy link
Contributor

  • Funded by: 3liz
  • Description:
    • Fixed by moving limit and sort setters under the filter setter

Gustry
Gustry approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gustry Gustry merged commit b24ca75 into 3liz:master Nov 8, 2024
7 checks passed
@Gustry
Copy link
Member

Gustry commented Nov 8, 2024

We could add just a simple line FILTER= in the unittest you added in #96

@neo-garaix neo-garaix deleted the fix-limit branch November 8, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gustry Gustry Gustry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neo-garaix @Gustry